Make agent host configurable #708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cf-foundation-community-automation
bot
moved this to Inbox
in Application Runtime Platform Working Group
9 tasks
pbusko
force-pushed
the
configurable-host
branch
from
12d57a7 to
9415ab0
Compare
Co-authored-by: Pavel Busko <[email protected]>
Co-authored-by: Jan von Loewenstein <[email protected]>
Co-authored-by: Pavel Busko <[email protected]>
pbusko
force-pushed
the
configurable-host
branch
from
9415ab0 to
ae21a45
Compare
github-project-automation
bot
moved this from Inbox
to Pending Merge | Prioritized
in Application Runtime Platform Working Group
github-project-automation
bot
moved this from Pending Merge | Prioritized
to Done
in Application Runtime Platform Working Group
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds possibility to configure host for the GRPC server, leaving previously hardcoded
127.0.0.1as the default value.Similar change has been already merged in cloudfoundry/diego-logging-client#123
Type of change
Testing performed?
Checklist:
mainbranch, or relevant version branchIf you have any questions, or want to get attention for a PR or issue please reach out on the #logging-and-metrics channel in the cloudfoundry slack